Skip to content

test: [Bigtable] Temporarily disable a flaky LargeRowIT integration case#13161

Merged
blakeli0 merged 2 commits into
googleapis:mainfrom
trollyxia:it
May 11, 2026
Merged

test: [Bigtable] Temporarily disable a flaky LargeRowIT integration case#13161
blakeli0 merged 2 commits into
googleapis:mainfrom
trollyxia:it

Conversation

@trollyxia
Copy link
Copy Markdown
Contributor

@trollyxia trollyxia commented May 11, 2026

Context: b/511286894

@trollyxia trollyxia requested review from a team as code owners May 11, 2026 17:48
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables the testWriteRead integration test in LargeRowIT.java using the @ignore annotation due to a server-side issue. The reviewer suggested improving the ignore message by hyphenating 'server-side' and recommended including a link to a tracking issue for better context and traceability.

}

@Test
@Ignore("Requires server side fix, temporarily disable flaky test until the fix is ready")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Including a link to a tracking issue in the @ignore message provides context for the required fix and helps track when the test can be re-enabled. Also, 'server-side' should be hyphenated when used as an adjective.

Suggested change
@Ignore("Requires server side fix, temporarily disable flaky test until the fix is ready")
@Ignore("Requires server-side fix, temporarily disable flaky test until the fix is ready")
References
  1. Stale comments can be kept if they are associated with a temporary code change, such as a disabled test.

@blakeli0 blakeli0 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 11, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 11, 2026
@blakeli0 blakeli0 merged commit ddfc837 into googleapis:main May 11, 2026
167 of 171 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants