Fix usages of bit provenance analysis that assume the source is bits-typed. - #4738
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_961055982
branch
3 times, most recently
from
August 9, 2026 06:37
aea3c97 to
819d34f
Compare
…typed. The select tree balancing pass + visibility analysis previously assumed that the source of a bit was always a bits type. If the source was a compound type (such as a tuple or array param), this assumption failed. This change updates BPA to materialize slices/indexing if needed in these cases. PiperOrigin-RevId: 961656119
copybara-service
Bot
force-pushed
the
test_961055982
branch
from
August 9, 2026 08:07
819d34f to
84bc29e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix usages of bit provenance analysis that assume the source is bits-typed.
The select tree balancing pass + visibility analysis previously assumed that the source of a bit was always a bits type. If the source was a compound type (such as a tuple or array param), this assumption failed. This change updates BPA to materialize slices/indexing if needed in these cases.