Fix a couple of comment loss scenarios in DSLX formatter. - #4705
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_958382992
branch
from
August 3, 2026 19:54
84a2968 to
82eeda5
Compare
These are cases that are hit when trying to auto-convert all of xls/examples to impl-style procs. Before this change, the formatter fails due to the self-detection of comment loss. PiperOrigin-RevId: 958595148
copybara-service
Bot
force-pushed
the
test_958382992
branch
from
August 3, 2026 22:02
82eeda5 to
4e772bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a couple of comment loss scenarios in DSLX formatter.
These are cases that are hit when trying to auto-convert all of xls/examples to impl-style procs. Before this change, the formatter fails due to the self-detection of comment loss.