[scheduling] Generalize fast-return logic - #4704
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_958351780
branch
2 times, most recently
from
August 3, 2026 16:41
6151502 to
6c41b85
Compare
When scheduling into one stage without a target clock period, even if we've been asked to attempt to explain failure to schedule, try the trivial schedule first. We only need to fall back to the full scheduler if we need to attempt to explain the problem. Also, if we are doing a binary search on `[start, end]`, we know `start` or `end` meets our criteria, and `start == end`, we can stop early without rechecking the criteria. This also uncovered a possible crash in `PipelineSchedule::ToProto` (previously impossible to reach in standard operation); this has now been converted to forward the `absl::Status` rather than crashing. PiperOrigin-RevId: 958515070
copybara-service
Bot
force-pushed
the
test_958351780
branch
from
August 3, 2026 19:26
6c41b85 to
d21bf97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[scheduling] Generalize fast-return logic
When scheduling into one stage without a target clock period, even if we've been asked to attempt to explain failure to schedule, try the trivial schedule first. We only need to fall back to the full scheduler if we need to attempt to explain the problem.
Also, if we are doing a binary search on
[start, end], we knowstartorendmeets our criteria, andstart == end, we can stop early without rechecking the criteria.This also uncovered a possible crash in
PipelineSchedule::ToProto(previously impossible to reach in standard operation); this has now been converted to forward theabsl::Statusrather than crashing.