Conversation
Taken from the upstream repo https://github.com/maxthunberg/miranda-sans at commit maxthunberg/miranda-sans@7cafa37.
FontSpector reportfontspector version: 1.5.4 Checks with FATAL resultsThese must be addressed first. [1] ofl/mirandasans/MirandaSans-Italic[wght].ttf💥 ERROR Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
[1] ofl/mirandasans/MirandaSans[wght].ttf💥 ERROR Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
All other checks[4] ofl/mirandasans/article/ARTICLE.en_us.html🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
🔥 FAIL DESCRIPTION.en_us.html must have more than 200 bytes. (googlefonts/description/min_length)
🔥 FAIL Is this a proper HTML snippet? (googlefonts/description/valid_html)
|
| MirandaSans-Italic[wght].ttf | |
|---|---|
| Dehinted Size | 82504 |
| Hinted Size | 82528 |
| Increase | 24 |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.000 [code: version-not-detected]
[5] ofl/mirandasans
🔥 FAIL Tofu should not be shown in sample texts. (googlefonts/tofu)
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Aleut, but although the font contained all the base exemplars for the language, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin:
- ̂ (U+0302) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Guarani, but although the font contained all the base exemplars for the language, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin:
- ẽ (U+1EBD) [code: missing-subsetted]
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Yanomamö, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin:
- ẽ (U+1EBD) [code: missing-subsetted]
⚠️ WARN Validate size, and resolution of article images,
and ensure article page has minimum length and includes visual assets. (googlefonts/article/images)
⚠️ WARN Article page lacks visual assets. [code: missing-visual-asset]
⚠️ WARN METADATA.pb subsets are correct? (googlefonts/metadata/subsets_correct)
⚠️ WARN Please remove 'latin-ext' from METADATA.pb since less than 20% of its glyphs are supported by this font file. [code: unsupported-subset]
⚠️ WARN Check for codepoints not covered by METADATA subsets. (googlefonts/metadata/unreachable_subsetting)
⚠️ WARN ofl/mirandasans/MirandaSans[wght].ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
- U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
- U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
- U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
- U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, math, tifinagh, cherokee
- U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
- U+0307 COMBINING DOT ABOVE: try adding one of: syriac, tai-le, tifinagh, canadian-aboriginal, coptic, old-permic, malayalam, duployan, math, todhri, hebrew
- U+030A COMBINING RING ABOVE: try adding one of: syriac, duployan
- U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
- U+030C COMBINING CARON: try adding one of: cherokee, tai-le
... and 33 others
Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu [code: unreachable-subsetting]
⚠️ WARN ofl/mirandasans/MirandaSans-Italic[wght].ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
- U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
- U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
- U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
- U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, math, tifinagh, cherokee
- U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
- U+0307 COMBINING DOT ABOVE: try adding one of: syriac, tai-le, tifinagh, canadian-aboriginal, coptic, old-permic, malayalam, duployan, math, todhri, hebrew
- U+030A COMBINING RING ABOVE: try adding one of: syriac, duployan
- U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
- U+030C COMBINING CARON: try adding one of: cherokee, tai-le
... and 33 others
Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu [code: unreachable-subsetting]
ℹ️ INFO Check axis ordering on the STAT table. (googlefonts/STAT/axis_order)
-
ℹ️ INFO None of the fonts lack a STAT table.
And these are the most common STAT axis orderings:
wght-ital: 2 [code: summary]
[9] ofl/mirandasans/MirandaSans[wght].ttf
⚠️ WARN Ensure variable fonts include an avar table. (mandatory_avar_table)
⚠️ WARN The font does not include an avar table. If the progression rates of axes is linear and no user-mapping is expected, this is fine, and this check can be ignored or excluded. [code: missing-avar]
⚠️ WARN Check font contains no unreachable glyphs (unreachable_glyphs)
⚠️ WARN The following glyphs could not be reached by codepoint or substitution rules:
- uni030C.alt [code: unreachable-glyphs]
⚠️ WARN Are there any misaligned on-curve points? (outline_alignment_miss)
⚠️ WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:
-
- ae (U+00E6): X=295,Y=2.5 (should be at baseline 0?)
-
- uni03BC (U+03BC): X=200.5,Y=2.5 (should be at baseline 0?)
-
- parenleft.caps: X=267.5,Y=718 (should be at cap-height 720?)
-
- parenright.caps: X=62.5,Y=718 (should be at cap-height 720?)
-
- braceleft.caps: X=271,Y=719 (should be at cap-height 720?)
-
- braceleft.caps: X=271,Y=1 (should be at baseline 0?)
-
- braceright.caps: X=109,Y=1 (should be at baseline 0?)
-
- braceright.caps: X=109,Y=719 (should be at cap-height 720?)
-
- uni00B5 (U+00B5): X=200.5,Y=2.5 (should be at baseline 0?) [code: found-misalignments]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
⚠️ WARN Checking OS/2 achVendID. (googlefonts/vendor_id)
⚠️ WARN OS/2 VendorID value 'THUN' is not yet recognized.
If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
[code: unknown]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| MirandaSans[wght].ttf | |
|---|---|
| Dehinted Size | 79692 |
| Hinted Size | 79716 |
| Increase | 24 |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.000 [code: version-not-detected]
[1] ofl/mirandasans/METADATA.pb
ℹ️ INFO Check METADATA.pb parses correctly (googlefonts/metadata/validate)
- ℹ️ INFO Please consider adding a family.minisite_url entry. [code: lacks-minisite-url]
Summary
| 💥 ERROR | 🔥 FAIL | ℹ️ INFO | ✅ PASS | ⏩ SKIP | |
|---|---|---|---|---|---|
| 2 | 6 | 15 | 10 | 260 | 65 |
| 1% | 2% | 4% | 3% | 73% | 18% |
FontSpector reportfontspector version: 1.5.4 Checks with FATAL resultsThese must be addressed first. [1] ofl/mirandasans/MirandaSans-Italic[wght].ttf💥 ERROR Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
[1] ofl/mirandasans/MirandaSans[wght].ttf💥 ERROR Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
All other checks[1] ofl/mirandasans/article/ARTICLE.en_us.htmlℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
[4] ofl/mirandasans🔥 FAIL Tofu should not be shown in sample texts. (googlefonts/tofu)
|
| MirandaSans[wght].ttf | |
|---|---|
| Dehinted Size | 79692 |
| Hinted Size | 79716 |
| Increase | 24 |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.000 [code: version-not-detected]
[9] ofl/mirandasans/MirandaSans-Italic[wght].ttf
⚠️ WARN Ensure variable fonts include an avar table. (mandatory_avar_table)
⚠️ WARN The font does not include an avar table. If the progression rates of axes is linear and no user-mapping is expected, this is fine, and this check can be ignored or excluded. [code: missing-avar]
⚠️ WARN Check font contains no unreachable glyphs (unreachable_glyphs)
⚠️ WARN The following glyphs could not be reached by codepoint or substitution rules:
- uni030C.alt [code: unreachable-glyphs]
⚠️ WARN Are there any misaligned on-curve points? (outline_alignment_miss)
⚠️ WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:
-
- ae (U+00E6): X=250,Y=2.5 (should be at baseline 0?)
-
- uni03BC (U+03BC): X=155,Y=2.5 (should be at baseline 0?)
-
- parenleft.caps: X=348.5,Y=718 (should be at cap-height 720?)
-
- parenright.caps: X=144,Y=718 (should be at cap-height 720?)
-
- braceleft.caps: X=352.5,Y=719 (should be at cap-height 720?)
-
- braceleft.caps: X=225.5,Y=1 (should be at baseline 0?)
-
- braceright.caps: X=64,Y=1 (should be at baseline 0?)
-
- braceright.caps: X=190.5,Y=719 (should be at cap-height 720?)
-
- uni00B5 (U+00B5): X=155,Y=2.5 (should be at baseline 0?) [code: found-misalignments]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
⚠️ WARN Checking OS/2 achVendID. (googlefonts/vendor_id)
⚠️ WARN OS/2 VendorID value 'THUN' is not yet recognized.
If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
[code: unknown]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| MirandaSans-Italic[wght].ttf | |
|---|---|
| Dehinted Size | 82504 |
| Hinted Size | 82528 |
| Increase | 24 |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.000 [code: version-not-detected]
[1] ofl/mirandasans/METADATA.pb
ℹ️ INFO Check METADATA.pb parses correctly (googlefonts/metadata/validate)
- ℹ️ INFO Please consider adding a family.minisite_url entry. [code: lacks-minisite-url]
Summary
| 💥 ERROR | 🔥 FAIL | ℹ️ INFO | ✅ PASS | ⏩ SKIP | |
|---|---|---|---|---|---|
| 2 | 3 | 13 | 11 | 264 | 65 |
| 1% | 1% | 4% | 3% | 74% | 18% |
|
Anything more I need to fix? 🤔 Watching with excitement 🥳🍿 @emmamarichal |
|
All good @maxthunberg, we just need a last review from @m4rc1e and here we go! |
Taken from the upstream repo https://github.com/maxthunberg/miranda-sans at commit maxthunberg/miranda-sans@7cafa37.
PR Checklist:
PR
QA
Specifics
primary_scriptdefinition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsetsdefinitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong,chinese-simplified,chinese-traditional,korean,japanese.Release
minisite_urldefinition in the METADATA.pb file for commissioned projectstagsare added for NEW FONTS