Refactor error handling and fix state persistence in LlmAgent#144
Merged
Refactor error handling and fix state persistence in LlmAgent#144
Conversation
f60767c to
8f4e296
Compare
1d3b0ec to
1829573
Compare
kalenkevich
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors error handling and state persistence in
LlmAgentto support robust Human-in-the-Loop (HITL) and client-side tool execution flows.Key Changes:
runAndHandleErrorto support nativeErrorobjects and ensures all exceptions (including those in post-processing or function execution) are caught and yielded as standardized error events.generateRequestConfirmationEventto ensureactions(includingstateDelta) are correctly persisted when the agent suspends for tool confirmation.pauseOnToolCallsin the agent loop, settingendInvocation = trueto return control to the host immediately after a tool call or confirmation request.callLlmAsyncandrunAndHandleErrortoprotectedvisibility and uses aTestLlmAgentsubclass to enable strictly typed unit testing withoutanycasts.Reference:
docs/adk-ts-improvements.mdFixes #143.