Rename standard_catalog to basic_catalog#656
Merged
gspencergoog merged 1 commit intogoogle:mainfrom Feb 23, 2026
Merged
Conversation
nan-yu
requested review from
dmandar,
gspencergoog,
jacobsimionato,
paullewis and
zeroasterisk
as code owners
Collaborator
Author
|
This will fix the build failure: https://github.com/google/A2UI/actions/runs/22327554629/job/64601908926?pr=620: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request successfully renames standard_catalog to basic_catalog across various files, including schema definitions, manager logic, tests, and documentation. The changes are consistent and align with the PR's objective. The description mentions a pre-launch checklist, but some items are unchecked. While not directly code-related, it's a good practice to ensure these are completed for a thorough review process.
A follow-up of PR#654 to replace remaining standard catalogs into basic catalogs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up of PR #654 to replace remaining standard catalogs into basic catalogs.
Description
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.