Fix 6 bugs: mutable default arg, log in loop, missing space, NoneType…#640
Fix 6 bugs: mutable default arg, log in loop, missing space, NoneType…#640MUTHUKUMARAN-K-1 wants to merge 2 commits intogoogle:mainfrom
Conversation
… crash, Button undefined child, os.path.join on URLs
MUTHUKUMARAN-K-1
requested review from
ava-cassiopeia,
ditman,
dmandar,
nan-yu,
paullewis and
zeroasterisk
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses six distinct bugs across the Python and TypeScript codebase, ranging from fixing a mutable default argument and a NoneType crash to improving logging efficiency and correcting URL handling. The changes are well-implemented and correctly resolve the identified issues. I have one suggestion to simplify the new URL joining logic for better readability and maintainability.
a2a_agents/python/a2ui_agent/src/a2ui/inference/schema/validator.py
Outdated
Show resolved
Hide resolved
…or.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
zeroasterisk
left a comment
zeroasterisk
left a comment
There was a problem hiding this comment.
one extra space, otherwise LGTM
| if attempt <= max_retries: | ||
| current_query_text = ( | ||
| "I received no response. Please try again." | ||
| "I received no response. Please try again. " |
There was a problem hiding this comment.
Is this an error? why the space after the period?
|
@MUTHUKUMARAN-K-1 can you please update the description of the PR to describe your changes, and maybe link to the github issue this fixes? |
4 participants
… crash, Button undefined child, os.path.join on URLs
Description
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.