[ fix ] : add missing license to angular package.json#632
Open
Dijo-404 wants to merge 3 commits intogoogle:mainfrom
Open
[ fix ] : add missing license to angular package.json#632Dijo-404 wants to merge 3 commits intogoogle:mainfrom
Dijo-404 wants to merge 3 commits intogoogle:mainfrom
Conversation
Dijo-404
requested review from
ava-cassiopeia,
crisbeto,
ditman,
dmandar,
jacobsimionato,
paullewis and
zeroasterisk
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly adds the missing license field to the package.json for the @a2ui/angular package and includes the license file in the build output. However, it also introduces several unrelated changes. The new root package-lock.json appears to be accidental, and the formatting changes in standard_catalog_definition.json add unnecessary noise. To improve maintainability and reviewability, it's recommended to keep pull requests focused on a single logical change.
renderers/web_core/src/v0_8/schemas/standard_catalog_definition.json
Outdated
Show resolved
Hide resolved
- Adds 'license': 'Apache-2.0' to package.json - Bumps version to 0.8.4 - Updates postprocess-build.mjs to copy LICENSE file to dist/
Dijo-404
force-pushed
the
fix/add-angular-license
branch
from
e0802cb to
d9ea3f0
Compare
gspencergoog
approved these changes
Feb 17, 2026
ava-cassiopeia
approved these changes
Feb 18, 2026
Collaborator
|
@jacobsimionato this bumps the package version, how do you want to handle release for that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Verification
Fixes #630