Skip to content

fix: replace tabs in query tables - #2642

Open
valoq wants to merge 2 commits into
gokcehan:masterfrom
valoq:tap
Open

fix: replace tabs in query tables#2642
valoq wants to merge 2 commits into
gokcehan:masterfrom
valoq:tap

Conversation

@valoq

@valoq valoq commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Fix for a regression from #2603
#2603 (comment)

the sanitizeName function applies on the entire line, including the tab that lf adds for the table display, wrongly replacing the intended tab.

The most simple way is to just use space instead of tabs, the results should be the same.

@CatsDeservePets CatsDeservePets left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don not like this approach as it changes the alignment.
When using the default tab widths of 8 inside lf and less, the difference is really visible:

Before:

After:

@valoq

valoq commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

We could just use sanitizePreview since it allows the use of tabs, but Im not sure I like that either since its a filename, not preview content.

@valoq
valoq requested a review from CatsDeservePets July 16, 2026 15:37
@valoq

valoq commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

@CatsDeservePets does the new solution work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants