Skip to content

Process minimum version from plist or set default value - #1362

Merged
jperedadnr merged 2 commits into
gluonhq:masterfrom
jperedadnr:1361-minosversion
Jun 16, 2026
Merged

Process minimum version from plist or set default value#1362
jperedadnr merged 2 commits into
gluonhq:masterfrom
jperedadnr:1361-minosversion

Conversation

@jperedadnr

Copy link
Copy Markdown
Contributor

Issue

Fixes #1361

Progress

Copilot AI review requested due to automatic review settings June 16, 2026 10:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the iOS packaging flow so MinimumOSVersion is no longer hard-coded to 12.0 and can be sourced from Default-Info.plist, falling back to a centralized default when missing/invalid. It also consolidates the default iOS minimum OS version into a shared constant for reuse across iOS build steps.

Changes:

  • Read MinimumOSVersion from the plist during iOS Info.plist processing and use it when generating the final plist.
  • Add validation/clamping of the minimum OS version with a default (Constants.DEFAULT_IOS_MIN_OS_VERSION).
  • Replace hard-coded -mios-version-min=12.0 flags with the centralized default constant.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/main/java/com/gluonhq/substrate/util/ios/InfoPlist.java Reads/validates MinimumOSVersion from the plist and applies it when generating the final Info.plist and when invoking Xcode tools.
src/main/java/com/gluonhq/substrate/target/IosTargetConfiguration.java Uses the centralized default iOS min OS version constant for compiler/linker flags.
src/main/java/com/gluonhq/substrate/Constants.java Introduces DEFAULT_IOS_MIN_OS_VERSION constant and updates copyright year.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/main/java/com/gluonhq/substrate/util/ios/InfoPlist.java
Comment thread src/main/java/com/gluonhq/substrate/util/ios/InfoPlist.java
@jperedadnr
jperedadnr merged commit a8d75ed into gluonhq:master Jun 16, 2026
3 checks passed
@jperedadnr
jperedadnr deleted the 1361-minosversion branch June 16, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iOS MinimumOSVersion ignored

2 participants