Process minimum version from plist or set default value - #1362
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the iOS packaging flow so MinimumOSVersion is no longer hard-coded to 12.0 and can be sourced from Default-Info.plist, falling back to a centralized default when missing/invalid. It also consolidates the default iOS minimum OS version into a shared constant for reuse across iOS build steps.
Changes:
- Read
MinimumOSVersionfrom the plist during iOSInfo.plistprocessing and use it when generating the final plist. - Add validation/clamping of the minimum OS version with a default (
Constants.DEFAULT_IOS_MIN_OS_VERSION). - Replace hard-coded
-mios-version-min=12.0flags with the centralized default constant.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/java/com/gluonhq/substrate/util/ios/InfoPlist.java | Reads/validates MinimumOSVersion from the plist and applies it when generating the final Info.plist and when invoking Xcode tools. |
| src/main/java/com/gluonhq/substrate/target/IosTargetConfiguration.java | Uses the centralized default iOS min OS version constant for compiler/linker flags. |
| src/main/java/com/gluonhq/substrate/Constants.java | Introduces DEFAULT_IOS_MIN_OS_VERSION constant and updates copyright year. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #1361
Progress