fix(ui): massive actions failing for plugins with namespaces - #25049
Open
eduardomozart wants to merge 3 commits into
Open
fix(ui): massive actions failing for plugins with namespaces#25049eduardomozart wants to merge 3 commits into
eduardomozart wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Closes #22614.
When plugins use namespaces for their classes (e.g.,
GlpiPlugin\Samlsso\RuleSamlCollection), the generatedcontainerID includes backslashes. When this ID is used in an inline JavaScript snippet to generate a jQuery selector, the single backslash evaluates properly as a JavaScript string literal, but fails when evaluated by jQuery's CSS selector engine. CSS requires literal backslashes to be double-escaped\\.This PR ensures that container IDs used in inline jQuery selectors within
Html.phpexplicitly have their backslashes escaped for CSS (by passing the string throughaddcslashes($container_id, '\\')prior tojsescape()). This correctly emits four backslashes\\\\into the JavaScript string literal, which evaluates to a double backslash\\in JavaScript, allowing jQuery to properly target the element ID.Html::getCheckAllAsCheckbox()Html::getCheckboxesFilter()Html::showMassiveActionsBlock()HtmlTest::testMassiveActionContainerIdEscapingScreenshots (if appropriate):