Skip to content

Fix: cover add-tile button rights with a regression test - #25028

Open
Rom1-B wants to merge 1 commit into
glpi-project:11.0/bugfixesfrom
Rom1-B:support_45219
Open

Fix: cover add-tile button rights with a regression test#25028
Rom1-B wants to merge 1 commit into
glpi-project:11.0/bugfixesfrom
Rom1-B:support_45219

Conversation

@Rom1-B

@Rom1-B Rom1-B commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !45219
  • Ensures the "Add tile" button on the helpdesk home configuration page only appears for users who actually have the rights to add a tile.

Screenshots (if appropriate):

@Rom1-B
Rom1-B requested review from froozeify and trasher July 31, 2026 09:42
@Rom1-B
Rom1-B requested review from AdrienClairembault and removed request for froozeify August 7, 2026 05:23

@AdrienClairembault AdrienClairembault left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to push part of the code?

It seems to me the current code is incomplete, you didn't modify any behavior.
I would say you added the canAddTile method to use its result as a condition in a twig template somewhere but it don't see it in the diff.

This also mean that the added tests proves nothing as there are no behavioral changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants