Fix: cover add-tile button rights with a regression test - #25028
Open
Rom1-B wants to merge 1 commit into
Open
Conversation
trasher
approved these changes
Aug 3, 2026
Rom1-B
requested review from
AdrienClairembault
and removed request for
froozeify
August 7, 2026 05:23
AdrienClairembault
requested changes
Aug 13, 2026
AdrienClairembault
left a comment
Member
There was a problem hiding this comment.
Did you forget to push part of the code?
It seems to me the current code is incomplete, you didn't modify any behavior.
I would say you added the canAddTile method to use its result as a condition in a twig template somewhere but it don't see it in the diff.
This also mean that the added tests proves nothing as there are no behavioral changes here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Screenshots (if appropriate):