feat: add Index field to Task parameters for merging items - #97
Merged
Conversation
- Introduced an `Index` field in TaskInitParameters, TaskObservation, and TaskParameters across v1alpha1 and v1beta1 APIs to facilitate merging of items in parent object lists. - Updated DeepCopy methods to handle the new `Index` field. - Adjusted job types to replace deprecated list map keys with the new `Index` key for tasks, environments, and job clusters. - Modified server-side apply merge strategies to utilize the new `Index` field for better item merging. - Updated CRDs to reflect the changes in the structure and added descriptions for the new `Index` field.
|
🎉 This PR is included in version 2.5.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indexfield in TaskInitParameters, TaskObservation, and TaskParameters across v1alpha1 and v1beta1 APIs to facilitate merging of items in parent object lists.Indexfield.Indexkey for tasks, environments, and job clusters.Indexfield for better item merging.Indexfield.Description of your changes
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested