ci: align stable and MSRV check/test coverage#989
Open
szokeasaurusrex wants to merge 1 commit intomasterfrom
Open
ci: align stable and MSRV check/test coverage#989szokeasaurusrex wants to merge 1 commit intomasterfrom
szokeasaurusrex wants to merge 1 commit intomasterfrom
Conversation
Member
Author
|
Let's do #977 before merging this PR, as that will allow us to change the names of the required jobs (otherwise, we need to reconfigure repo settings for the CI to pass, as job names have changed). We can already review this, though |
lcian
reviewed
Feb 12, 2026
lcian
approved these changes
Feb 12, 2026
Member
lcian
left a comment
lcian
left a comment
There was a problem hiding this comment.
LGTM but the downside is that you'll have to keep the version here in this file in sync with the MSRV
Member
Author
The previous approach had the same limitation. I agree, we can probably improve this in the future though! |
szokeasaurusrex
force-pushed
the
szokeasaurusrex/align-msrv-stable
branch
from
c4ca361 to
a2d729b
Compare
szokeasaurusrex
changed the base branch from
master
to
szokeasaurusrex/aggregator-ci-job
szokeasaurusrex
force-pushed
the
szokeasaurusrex/aggregator-ci-job
branch
from
2fd4b13 to
dd20d9a
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/align-msrv-stable
branch
from
a2d729b to
3a299f7
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
szokeasaurusrex
force-pushed
the
szokeasaurusrex/align-msrv-stable
branch
2 times, most recently
from
aa10914 to
79493ef
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/aggregator-ci-job
branch
2 times, most recently
from
4a96f97 to
c15d28c
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/align-msrv-stable
branch
from
79493ef to
b44e15f
Compare
Run both check and test over a shared os×rust matrix for stable and 1.88.0, and remove the standalone MSRV job to reduce drift. Keep check permutations identical across toolchains, add explicit workspace doc-test runs in test, and retain an explicit sentry default+test feature assertion with an inline rationale comment. Closes #974 Closes [RUST-140](https://linear.app/getsentry/issue/RUST-140/align-msrv-and-stable-ci-coverage-including-doc-tests)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/align-msrv-stable
branch
from
b44e15f to
99e7f73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Run both check and test over a shared os×rust matrix for stable and 1.88.0, and remove the standalone MSRV job to reduce drift.
Keep check permutations identical across toolchains, add explicit workspace doc-test runs in test, and retain an explicit sentry default+test feature assertion with an inline rationale comment.
Issues
Closes #974
Closes RUST-140