ci: Replace make targets and remove Makefile#987
Conversation
szokeasaurusrex
changed the title
Replace CI make invocations with explicit cargo commands to make workflow behavior easier to read directly in the CI config. Remove the root Makefile to avoid maintaining a separate command layer in addition to the workflow definitions. Closes GH-973 Closes [RUST-139](https://linear.app/getsentry/issue/RUST-139/delete-the-makefile-and-remove-references)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/no-makefile
branch
from
054861d to
bb54a45
Compare
| run: cargo check | ||
| working-directory: sentry-actix | ||
| env: | ||
| RUSTFLAGS: -Dwarnings |
There was a problem hiding this comment.
We could probably expand this by checking each of the subcrates individually, I think we just forgot to add them to the makefile as new crates were created
There was a problem hiding this comment.
Is there any benefit to checking the sub crates individually? Shouldn't we just run check at the workspace level?
There was a problem hiding this comment.
Yeah but you would also need to make sure you're selecting the features that enable a particular subcrate.
e.g. instead of cargo check in sentry-actix working directory you would cargo check sentry with the actix feature, etc.
There was a problem hiding this comment.
Ok, got it. Let's do this in a later PR; for now I am trying to keep a narrow scope on the CI improvement effort
2 participants
Replace CI make invocations with explicit cargo commands to make workflow behavior easier to read directly in the CI config.
Remove the root Makefile to avoid maintaining a separate command layer in addition to the workflow definitions.
Stacked on #986
Closes GH-973
Closes RUST-139