Draft
Conversation
Match the TOML version catalog format when overriding Spring Boot versions in matrix jobs. Preserve whitespace around the assignment and replace the quoted version value so the CI jobs actually test the requested matrix version. Co-Authored-By: Claude <noreply@anthropic.com>
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 674d437 | 355.28 ms | 504.18 ms | 148.90 ms |
| 2195398 | 321.31 ms | 391.66 ms | 70.35 ms |
| 62b579c | 312.88 ms | 361.57 ms | 48.70 ms |
| b77456b | 393.26 ms | 441.10 ms | 47.84 ms |
| 694d587 | 312.37 ms | 402.77 ms | 90.41 ms |
| 6b019b7 | 319.84 ms | 333.15 ms | 13.31 ms |
| 6edfca2 | 305.52 ms | 432.78 ms | 127.26 ms |
| b03edbb | 314.90 ms | 350.22 ms | 35.33 ms |
| d15471f | 294.13 ms | 399.49 ms | 105.36 ms |
| fcec2f2 | 314.96 ms | 373.66 ms | 58.70 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 674d437 | 1.58 MiB | 2.10 MiB | 530.94 KiB |
| 2195398 | 0 B | 0 B | 0 B |
| 62b579c | 0 B | 0 B | 0 B |
| b77456b | 1.58 MiB | 2.12 MiB | 548.11 KiB |
| 694d587 | 1.58 MiB | 2.19 MiB | 620.06 KiB |
| 6b019b7 | 0 B | 0 B | 0 B |
| 6edfca2 | 1.58 MiB | 2.13 MiB | 559.07 KiB |
| b03edbb | 1.58 MiB | 2.13 MiB | 557.32 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| fcec2f2 | 1.58 MiB | 2.12 MiB | 551.50 KiB |
The matrix jobs now actually update the version catalog. Remove Spring Boot versions that the current sample setup cannot build with the repository's Spring GraphQL integrations and Gradle version. Co-Authored-By: Claude <noreply@anthropic.com>
Expand the Spring Boot 2 and 3 CI matrices to cover supported minor versions. Exclude GraphQL from Spring Boot 2 versions before 2.7 because the starter is unavailable there. Keep the Spring Boot 3 Gradle plugin pinned to a Gradle-compatible version while importing the tested Spring Boot BOM in samples, so the matrix exercises the intended runtime dependencies. Co-Authored-By: Claude <noreply@anthropic.com>
Remove the explicit elastic scheduler from the Spring Boot WebFlux sample. Mono.delay already schedules the delayed work, and using Schedulers.elastic triggers deprecation warnings that fail CI under -Werror. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix the Spring Boot 2.x, 3.x, and 4.x matrix workflows so their version override matches the TOML version catalog format.
The workflows now preserve whitespace around the assignment and replace the quoted Spring Boot version value in
gradle/libs.versions.toml.💡 Motivation and Context
The existing
sedexpressions looked for keys without spaces around=, but the version catalog uses entries likespringboot2 = "2.7.18". As a result, matrix jobs did not actually update the Spring Boot version under test.💚 How did you test it?
sedexpressions against a temporary copy ofgradle/libs.versions.tomland verified Spring Boot 2, 3, and 4 versions were updated../gradlew spotlessApply apiDump.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog