feat(attributes): Add missing_instrumentation.* attributes#366
Closed
chargome wants to merge 1 commit into
Closed
Conversation
Add missing_instrumentation.package and missing_instrumentation.javascript.is_cjs attributes for detecting uninstrumented packages in the JS SDK. Needed for span streaming (JS-2221). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chargome
requested review from
a team,
Lms24,
cleptric,
mjq and
nsdeschenes
as code owners
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Member
Author
|
I think this is not really useful on spans tbh, let's skip it for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
missing_instrumentation.package(string) — the name of the uninstrumented packagemissing_instrumentation.javascript.is_cjs(boolean) — whether the package was loaded as CommonJS