WIP: add deepseek-v4-flash to builder pool - #930
Conversation
|
Documentation Changes Added
Actions
If neither actions are selected, on PR close/merge the docs branch in ReadMe will remain open. |
Kimchi Code Review
Summary📊 Review Score: 74/100 (overall code quality — 0 lowest, 100 highest) 🧪 Tests: yes — Tests were added in 📝 Found 2 issue(s). See inline comments for details. What to expectKimchi will analyze the changes in this pull request and post:
The review typically completes within a few minutes. This comment will be updated once the review is ready. Interact with Kimchi
ConfigurationReviews are configured by your organization admin. Powered by Kimchi — AI-powered code review by CAST AI |
There was a problem hiding this comment.
📊 Review Score: 74/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 2/5 (1 = trivial, 5 = very complex)
🧪 Tests: yes — Tests were added in src/extensions/orchestration/model-registry/builtin-models.test.ts to verify build guidelines for deepseek-v4-flash, and model-roles.test.ts was updated to assert the new builder pool membership. However, the new builtin-models test uses the wrong sentinel string ("ignored" instead of "ignore") in its guard.
📝 Found 2 issue(s). See inline comments for details.
| expect(k26.description).toContain("planning decisions") | ||
| }) | ||
|
|
||
| it("deepseek-v4-flash has build guidelines now that it is a builder candidate", () => { |
There was a problem hiding this comment.
The test guards against the literal string "ignored", but MODEL_CAPABILITIES uses "ignore" as its sentinel value. This makes the if (!deepseek || deepseek === "ignored") return guard ineffective and the expect(deepseek).not.toBe("ignored") assertion misleading. If the map entry were ever set to "ignore", the test would either fail with a confusing property-access assertion or produce a TypeScript compile error because the ModelCapabilities | "ignore" union is not properly narrowed.
💡 Suggestion: Change both occurrences of "ignored" to "ignore" so the guard and assertion correctly handle the ModelCapabilities | "ignore" union type: expect(deepseek).not.toBe("ignore") and if (!deepseek || deepseek === "ignore") return.
…adata
Linked issue
Closes #
What does this PR do?
Checklist
pnpm run test)pnpm run check)