Feat/subagent output improvements - #867
Conversation
Kimchi Code Review
Summary📊 Review Score: 88/100 (overall code quality — 0 lowest, 100 highest) 🧪 Tests: yes — Two new focused tests cover the foreground streaming behavior: one verifies that actual text deltas are forwarded to No significant issues found. LGTM! 🎉 What to expectKimchi will analyze the changes in this pull request and post:
The review typically completes within a few minutes. This comment will be updated once the review is ready. Interact with Kimchi
ConfigurationReviews are configured by your organization admin. Powered by Kimchi — AI-powered code review by CAST AI |
There was a problem hiding this comment.
📊 Review Score: 88/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 3/5 (1 = trivial, 5 = very complex)
🧪 Tests: yes — Two new focused tests cover the foreground streaming behavior: one verifies that actual text deltas are forwarded to onUpdate instead of the old 'x tool uses...' placeholder, and another verifies that spinner-only ticks emit empty content to avoid duplicate ACP payloads. The test mock was also expanded with invokeCallback, setSession, and resolveSpawnPromise helpers, making the foreground agent lifecycle more realistic.
No significant issues found. LGTM! 🎉
525b31f to
553644d
Compare
|
This PR has been marked as stale because it has not had recent activity. It will be closed tomorrow if no further activity occurs. |
Linked issue
Closes #
What does this PR do?
Checklist
pnpm run test)pnpm run check)