Skip to content

Feat/subagent output improvements - #867

Draft
vmizg wants to merge 2 commits into
masterfrom
feat/subagent-output-improvements
Draft

Feat/subagent output improvements#867
vmizg wants to merge 2 commits into
masterfrom
feat/subagent-output-improvements

Conversation

@vmizg

@vmizg vmizg commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Linked issue

Closes #

What does this PR do?

Checklist

  • I have read CONTRIBUTING.md and agree to the CLA
  • This PR links to an open issue above
  • Tests pass locally (pnpm run test)
  • Lint passes (pnpm run check)
  • Documentation updated if behavior changed

@kimchi-review

kimchi-review Bot commented Jul 16, 2026

Copy link
Copy Markdown

Kimchi Code Review

Property Value
Commit 525b31f
Author @vmizg
Files changed 0
Review status Completed
Comments 0
Duration 61s

Summary

📊 Review Score: 88/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 3/5 (1 = trivial, 5 = very complex)

🧪 Tests: yes — Two new focused tests cover the foreground streaming behavior: one verifies that actual text deltas are forwarded to onUpdate instead of the old 'x tool uses...' placeholder, and another verifies that spinner-only ticks emit empty content to avoid duplicate ACP payloads. The test mock was also expanded with invokeCallback, setSession, and resolveSpawnPromise helpers, making the foreground agent lifecycle more realistic.

No significant issues found. LGTM! 🎉

What to expect

Kimchi will analyze the changes in this pull request and post:

  • A summary of the overall changes
  • Inline comments on specific lines with findings categorized by issue type

The review typically completes within a few minutes. This comment will be updated once the review is ready.

Interact with Kimchi
  • @getkimchi review — re-trigger a full review on the latest commit
  • @getkimchi summary — regenerate the PR summary
  • @getkimchi ignore — skip this PR (no review will be posted)
  • Reply to any inline comment to ask follow-up questions or request clarification
Configuration

Reviews are configured by your organization admin.
Review instructions, excluded directories, and severity thresholds can be adjusted per repository in the Kimchi dashboard.


Powered by Kimchi — AI-powered code review by CAST AI

@kimchi-review kimchi-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📊 Review Score: 88/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 3/5 (1 = trivial, 5 = very complex)

🧪 Tests: yes — Two new focused tests cover the foreground streaming behavior: one verifies that actual text deltas are forwarded to onUpdate instead of the old 'x tool uses...' placeholder, and another verifies that spinner-only ticks emit empty content to avoid duplicate ACP payloads. The test mock was also expanded with invokeCallback, setSession, and resolveSpawnPromise helpers, making the foreground agent lifecycle more realistic.

No significant issues found. LGTM! 🎉

@vmizg
vmizg force-pushed the feat/subagent-output-improvements branch from 525b31f to 553644d Compare July 16, 2026 08:08
@github-actions

Copy link
Copy Markdown

This PR has been marked as stale because it has not had recent activity. It will be closed tomorrow if no further activity occurs.

@github-actions github-actions Bot added the stale No recent activity label Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale No recent activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant