Feat/help command sync - #564
Conversation
Users could run 40+ commands but /help only listed ~17; group entries by topic and add regression tests so discoverability stays in sync. Co-authored-by: Cursor <cursoragent@cursor.com>
|
📚 No documentation changes were needed for this PR (Job ID: |
Kimchi Code Review
Summary📊 Review Score: 95/100 (overall code quality — 0 lowest, 100 highest) 🧪 Tests: yes — Thorough test coverage added in No significant issues found. LGTM! 🎉 What to expectKimchi will analyze the changes in this pull request and post:
The review typically completes within a few minutes. This comment will be updated once the review is ready. Interact with Kimchi
ConfigurationReviews are configured by your organization admin. Powered by Kimchi — AI-powered code review by CAST AI |
|
@getkimchi review |
|
A review is already in progress for commit |
![kimchi-review[bot]](https://avatars.githubusercontent.com/in/3223788?s=60&v=4){kind=small}
There was a problem hiding this comment.
📊 Review Score: 95/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 1/5 (1 = trivial, 5 = very complex)
🧪 Tests: yes — Thorough test coverage added in src/extensions/help.test.ts. Tests validate that high-value and Kimchi-specific commands are present, upstream/internal commands are excluded, the help uses subsection headings, and the getHelpCommandKeys utility behaves correctly.
No significant issues found. LGTM! 🎉
|
Thanks for taking a look when you have time. This expands Related to #554 discoverability. Supersedes the Happy to add a |
|
Hello there @kr3shna Could you also provide some screenshots of the before / after? |
Resolve /help conflict by keeping the sectioned layout and adding upstream /todos under Kimchi. Extend help.test.ts to cover /todos.
Before / afterBefore (upstream master) — single flat "Slash Commands" list: After — sectioned 
|
Let me know if you'd like additional crops or scroll positions. |
|
This PR has been marked as stale because it has not had recent activity. It will be closed tomorrow if no further activity occurs. |
|
@castabar please can review it once |
2 participants
Description
The TUI
/helpoverlay only listed ~17 slash commands while users can run 40+ (upstream pi commands plus Kimchi extensions). Hidden commands included session tools (/name,/session,/resume,/import,/export), auth (/login,/logout), and Kimchi-only tools (/teleport,/clear,/mcp-auth, etc.).This PR restructures
HELP_ROWSinsrc/extensions/help.tsinto topic sections (Session, Model, Kimchi, MCP & resources, Teleport, Settings & auth, Utility), adds upstream commands with curated descriptions, and documents/exit(not upstream/quit). Addssrc/extensions/help.test.tswith regression checks so internal commands like/cc-toolsstay out of help.Related to #554 (same discoverability theme; broader than rename-only). Supersedes the
/name-only slice in #561 if that PR is still open.Type of Change
Test plan
pnpm run checkKIMCHI_PROXY_HELPER=$(pwd)/bin/proxy-helper pnpm run test src/extensions/help.test.tspnpm run dev→/help→ scroll all sections (verified at 80×24 via overlay scroll simulation + live PTY)/exitis listed (not/quit) — verified inhelp.test.tsand overlay content