fix(install): correct repo refs and handle Windows shells - #552
fix(install): correct repo refs and handle Windows shells#552SharanKarchella wants to merge 1 commit into
Conversation
scripts/install.sh defaulted REPO to castai/kimchi and the usage comment used the same URL. The project moved to getkimchi/kimchi, so these only work via GitHub's transfer redirect today and break if the old name is ever recreated. Git Bash, MSYS2 and Cygwin report mingw*/msys*/cygwin* from `uname -s` and fell through to the catch-all, which printed "Windows: download the .zip" -- pointing at an artifact no release ships (v0.1.17 has only darwin/linux tarballs). That misleading message is the bug in getkimchi#546. - Default REPO and the usage URL to getkimchi/kimchi - Match mingw*|msys*|cygwin* explicitly and direct users to WSL - Replace the dead .zip hint in the catch-all with honest guidance Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Kimchi Code Review
Summary📊 Review Score: 98/100 (overall code quality — 0 lowest, 100 highest) 🧪 Tests: no — No test files were modified. Install scripts are conventionally validated manually, and the diff contains only safe textual changes to URLs and error messages. No significant issues found. LGTM! 🎉 What to expectKimchi will analyze the changes in this pull request and post:
The review typically completes within a few minutes. This comment will be updated once the review is ready. Interact with Kimchi
ConfigurationReviews are configured by your organization admin. Powered by Kimchi — AI-powered code review by CAST AI |
|
📚 No documentation changes were needed for this PR (Job ID: |
![kimchi-review[bot]](https://avatars.githubusercontent.com/in/3223788?s=60&v=4){kind=small}
There was a problem hiding this comment.
📊 Review Score: 98/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 1/5 (1 = trivial, 5 = very complex)
🧪 Tests: no — No test files were modified. Install scripts are conventionally validated manually, and the diff contains only safe textual changes to URLs and error messages.
No significant issues found. LGTM! 🎉
|
This PR has been marked as stale because it has not had recent activity. It will be closed tomorrow if no further activity occurs. |
2 participants
Description
scripts/install.shhad three related problems:REPOdefaulted tocastai/kimchi, and the usagecomment (
curl … | bash) used the same URL. The project moved togetkimchi/kimchi; the old path only resolves today via GitHub'stransfer redirect, which silently breaks (or could be hijacked) if
castai/kimchiis ever recreated.report
mingw*/msys*/cygwin*fromuname -s. These fell throughto the catch-all
*)arm and printedWindows: download the .zip from …..zipthat doesn't exist. The latest release(
v0.1.17) ships onlykimchi_{darwin,linux}_{amd64,arm64}.tar.gz— thereis no Windows artifact at all.
Changes
REPOdefault and the usage-comment URL atgetkimchi/kimchi.mingw*|msys*|cygwin*explicitly and tell users there is nonative Windows build yet, directing them to run the installer inside WSL
(where the Linux build works).
.ziphint in the catch-all with honest text that pointsat the releases page and states the supported platforms (macOS + Linux).
Verification
bash -n scripts/install.shpasses.uname -svia a shim:MINGW64_NT-10.0,MSYS_NT-10.0,CYGWIN_NT-10.0→ WSL guidance, exit 1.Plan9) → "macOS and Linux only" catch-all, exit 1.Installing Kimchi from getkimchi/kimchi.Closes #546
Type of Change