Conversation
Move preview.js from the bookshop module into a dedicated optional preview module to prevent a TDZ runtime error in the production core bundle. Hugo's concatenate-then-minify pipeline caused closure variables in the nested forEach callbacks to collide after minification. - Add [params.modules.preview] with integration = "optional" - Move assets/js/modules/bookshop/preview.js → assets/js/modules/preview/preview.js - Wrap preview.js in an IIFE to isolate module-level consts from the concatenated bundle scope - Warn at build time when a page uses the preview block without declaring modules: ["preview"] in its front matter; guard with page.IsPage to avoid false positives on section index pages Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
🎉 This PR is included in version 1.22.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move preview.js from the bookshop module into a dedicated optional preview module to prevent a TDZ runtime error in the production core bundle. Hugo's concatenate-then-minify pipeline caused closure variables in the nested forEach callbacks to collide after minification.