docs: fix mode-solver plot titles and add TFLN band diagram - #198
Merged
Conversation
- Fix overlapping title/axis labels in rib & tfln interactive Plotly field-map plots; shorten titles to params + n_eff only - Add a width-sweep band diagram to the TFLN notebook: 25 w0 points, 8 bands, parallel cloud submission (batches of 10), square plot
vvahidd
requested review from
cdaunt,
flaport,
joamatab and
nikosavola
as code owners
July 25, 2026 04:15
github-actions
Bot
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vertical_spacing, taller figure, explicit margins). Titles now show only params +n_effinstead of the long descriptive text.w0from 0.3→3.0 µm (25 points), solving the first 8 bands at each width and plottingn_effvsw0(radiative modes below the SiO₂ cladding index are dropped). Rendered as a square interactive Plotly figure.tickets.md— a completed planning doc (all items shipped).The sweep submits each width as an independent cloud mode-solve, batched at 10 concurrent jobs (
gcloud.upload/startnon-blocking →wait_for_results), so it finishes in a few minutes rather than one width at a time.Notebooks were re-executed via
just nbrun-docs;docs/nbs/*.mdare regenerated by CI from the committed.ipynb.