Replace ubcpdk with gdsfactory.components in example notebooks#183
Open
jackgdsf wants to merge 2 commits into
Open
Replace ubcpdk with gdsfactory.components in example notebooks#183jackgdsf wants to merge 2 commits into
jackgdsf wants to merge 2 commits into
Conversation
…ooks All 9 notebooks under nbs/ that imported ubcpdk now use gdsfactory.components and gf.gpdk.PDK instead, removing the external PDK dependency for running examples. Component mapping: - cells.straight → gf.components.straight - cells.bend_s → gf.components.bend_s - cells.coupler → gf.components.coupler - cells.coupler_ring → gf.components.coupler_ring - cells.ebeam_y_1550 → gf.components.mmi1x2 - cells.ebeam_crossing4 → gf.components.crossing45
jackgdsf
requested review from
cdaunt,
flaport,
joamatab,
nikosavola and
vvahidd
as code owners
June 29, 2026 13:30
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
==========================================
+ Coverage 59.43% 60.76% +1.32%
==========================================
Files 62 65 +3
Lines 8804 9665 +861
Branches 1755 1946 +191
==========================================
+ Hits 5233 5873 +640
- Misses 3016 3128 +112
- Partials 555 664 +109 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- _palace_dc.ipynb: reorder imports (gdsfactory as gf before gdsfactory.component) - meep_2d.ipynb: fix doubled gf.gpdk.gf.gpdk.PDK.activate() → gf.gpdk.PDK.activate()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #182
Summary
ubcpdkimports in 9 example notebooks withgdsfactory.componentsequivalentsgf.gpdk.PDK.activate()instead of ubcpdk PDK activation.pyand.ipynbfiles updated consistentlyComponent mapping
cells.straightgf.components.straightcells.bend_sgf.components.bend_scells.couplergf.components.couplercells.coupler_ringgf.components.coupler_ringcells.ebeam_y_1550gf.components.mmi1x2cells.ebeam_crossing4gf.components.crossing45Affected files (20)
9
.py+ 9.ipynbnotebook pairs, plusmeep_2d.py/.ipynb(header update only)Test plan
Reminder: AI-created PRs still require human review of the actual code changes before merge. I will open the PR, but a human must review and approve it.