feat(eim): variational effective-index method for 2D FDTD #156#161
Draft
thanojo wants to merge 7 commits into
Draft
feat(eim): variational effective-index method for 2D FDTD #156#161thanojo wants to merge 7 commits into
thanojo wants to merge 7 commits into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #156 by adding a variational effective-index method (varEIM) that derives the in-plane permittivity for 2D FDTD from the vertical slab mode of the 3D stack (Hammer & Ivanova 2009), instead of bulk indices.
src/gsim/meep/eim.py:variational_effective_permittivity(), 1D finite-difference slab solver,build_eps_zfrom the layer stack, and a zero-dispersionfit_mediumstub.nbs/meep_ybranch_veim.py: Y-branch 2D varEIM vs 3D comparison notebook (+ docs nav entry).This is a first cut — more to do:
fit_mediumstub).sim.solver(is_3d=False, eim="variational")).Scope now: TE-only, single reference mode, single wavelength.
Separate finding (not in this PR): 3D waveguide-port S-params under-read by several dB since the Apr-22 "right-size port monitors" change — the in-plane
port_marginundersizes the 3D eigenmode source/monitors. Worth its own issue.