Update comunica to latest#213
Merged
GCHQDeveloper81 merged 2 commits intomainfrom May 1, 2026
Merged
Conversation
Member
Author
|
@rubensworks FYI - upgraded to 5.2.0, found a couple of breaking changes that may affect others. Workarounds described above, in case any other users have the same issues. |
|
Thanks for the ping, that was an oversight indeed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upgrade to comunica@5.2.0 turned out to have a few breaking changes, which are addressed by this PR.
Logger
This project has a logger that is used for "general logging" but also passed to comunica's engine so it can also write to the same logs. This has worked fine up to now because both loggers followed a fairly standard pattern , however comunica has now introduced a performance enhancement that expects the engine's logger to have a
flushfunction among other things, which our logger doens't. These have been stubbed out for now (which means we don't get that functionality) - will revisit in the future.Vite and LRU-CACHE
We started getting a warning after upgrading:
Which eventually manifested as an error when we instantiated a Comunica engine. After a bit of research it turned out to be related to the
lru-cachemodule, which has introduced conditional exports that were incompatible with the vite defaults, meaning some kind of node-specific functionality that was being picked up in the browser (almost certainly this was caused by this commit from a few weeks ago). Comunica's new release must've bumped this version and they've picked up the issue.This was one of those really nasty bugs where the cause did not match the symptom, and how it manifests/the error it gives may differ depending on what the app is doing - bad news for anyone who misses the original warning.
The fix was just to be a bit more explicit in the vite config (see PR).