NavSat::ToElement() method (backport #1585)#1638
Merged
Merged
Conversation
Contributor
Author
|
Cherry-pick of 8ccc60c has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
scpeters
force-pushed
the
mergify/bp/sdf14/pr-1585
branch
from
48f0c55 to
b2446c0
Compare
Member
|
I rebased and resolved conflicts |
scpeters
reviewed
Apr 17, 2026
| elem->GetElement("update_rate")->Set<double>(_errors, this->UpdateRate()); | ||
| elem->GetElement("enable_metrics")->Set<double>(_errors, | ||
| this->EnableMetrics()); | ||
| >>>>>>> 8ccc60cd (NavSat::ToElement() method (#1585)) |
Member
There was a problem hiding this comment.
resolved conflicts again and removed the frame_id field, since that was added in Ionic
`sdf::NavSat` didn't have a `ToElement()` method which prevent to convert sensor-specific information back to sdf format. This PR include such changes: * Introduce `sdf::NavSat::ToElement()` method * Added this method call to dispatcher in `Sensor::ToElement()` * Also same dispatcher had misleading error msg: if user tried to convert sensor w/o sensor-specific information it will get error message about lack of this feature, but actually it's not correct. Dispatcher logic changed to avoid such misleading (split apart type check and pointer check) * And message was w/o trailing new_line symbol which makes console output harder to read * Added test for new ToElement() method; valgrind is happy * Couple of typos fixed --------- Signed-off-by: Maksim Derbasov <ntfs.hard@gmail.com> (cherry picked from commit 8ccc60c)
scpeters
force-pushed
the
mergify/bp/sdf14/pr-1585
branch
from
b2446c0 to
36b7248
Compare
Member
|
requesting other an alternate reviewer since I resolved conflicts |
azeey
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #
Summary
sdf::NavSatdidn't have aToElement()method which prevent to convert sensor-specific information back to sdf format.This PR include such changes:
sdf::NavSat::ToElement()methodSensor::ToElement()This PR was developed on top of sdf15 and retargeted to sdf16 due to sdf16 do not have dev packages.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.This is an automatic backport of pull request #1585 done by Mergify.