Conversation
ninaiiad
force-pushed
the
ng/discovery
branch
2 times, most recently
from
5b521cb to
37113a0
Compare
vladimir-ea
reviewed
Apr 9, 2026
vladimir-ea
reviewed
Apr 9, 2026
vladimir-ea
reviewed
Apr 9, 2026
vladimir-ea
reviewed
Apr 9, 2026
vladimir-ea
reviewed
Apr 9, 2026
vladimir-ea
reviewed
Apr 9, 2026
| signature, | ||
| }) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
we should consider keeping ENR records in RLP format and not decoding / encoding
Collaborator
There was a problem hiding this comment.
maybe future optimisation?
vladimir-ea
reviewed
Apr 9, 2026
| #[derive(Copy, Clone, PartialEq, Eq, Default, PartialOrd, Ord, Debug)] | ||
| pub struct Distance(U256); | ||
|
|
||
| pub const MAX_NODES_PER_BUCKET: usize = 16; |
vladimir-ea
reviewed
Apr 9, 2026
| nodes: ArrayVec<Node<T>, MAX_NODES_PER_BUCKET>, | ||
| pending: Option<PendingNode<T>>, | ||
| pending_timeout: Duration, | ||
| } |
Collaborator
There was a problem hiding this comment.
lets return to this and consider simplifying
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.