Open
Conversation
|
@garycourt can you please merge this and publish a new package? It is currently also breaking builds with electron-rebuilder, see: electron-userland/electron-builder#3050. |
|
@garycourt Please merge it 🙏 |
mtgto
added a commit
to mtgto/bdash
that referenced
this pull request
Nov 24, 2019
- Update Electron to latest v7
- Rename roles of submenu ex. hideall -> hideAll
- Set nodeIntegration to true to use node in renderer process
- Add hack to use setImmediate in renderer process
- Update Webpack to latest v4
- Use webpack's mode argument instead of BUILD_ENV
- Use mini-css-extract-plugin instead of outdated extracted-text-webpack plugin
- Update electron-builder to latest v21
- Update TypeScript to latest v3.7
- Current @types/electron contains unknown not supported in TS 2.9
- Update plotly.js to latest v1.15
- Avoid to use JSV depends on plotly.js
- JSV contains broken package.json
- garycourt/JSV#95
- Update spectron to latest v9
- Support Electron v7
|
Is there anything stopping this from getting merged in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to stop breaking manual uploading to Artifactory servers.