Skip to content

fix(skills): Use CLAUDE_PLUGIN_ROOT in hook paths#970

Open
Gujiassh wants to merge 1 commit intogarrytan:mainfrom
Gujiassh:fix/claude-plugin-root-hooks
Open

fix(skills): Use CLAUDE_PLUGIN_ROOT in hook paths#970
Gujiassh wants to merge 1 commit intogarrytan:mainfrom
Gujiassh:fix/claude-plugin-root-hooks

Conversation

@Gujiassh
Copy link
Copy Markdown

Summary

  • replace legacy CLAUDE_SKILL_DIR hook and inline skill-path references with CLAUDE_PLUGIN_ROOT
  • regenerate the affected skill docs so the shipped Claude skills and ship workflow stay aligned
  • add regression checks to block future reintroduction of CLAUDE_SKILL_DIR in templates or generated skills

Fixes #961

Validation

  • bun test test/gen-skill-docs.test.ts -t 'legacy CLAUDE_SKILL_DIR'
  • rg -n "CLAUDE_SKILL_DIR" careful freeze guard investigate ship scripts/resolvers/review.ts test/gen-skill-docs.test.ts

Notes

  • bun test test/gen-skill-docs.test.ts test/host-config.test.ts still reports pre-existing main-branch drift unrelated to this patch (package.json version 0.16.2.0 vs VERSION 0.16.3.0, plus stale ship golden baselines).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hook commands reference ${CLAUDE_SKILL_DIR} but Claude Code only exposes ${CLAUDE_PLUGIN_ROOT} — all skill-registered hooks silently broken

1 participant