Closed
Conversation
- added a tagging system to the blog posts in order to satisfy Apeiro requirement - added tags to existing blog posts - improved the view of the blogs - added author name + picture for each post - converted Hugo shortcode syntax inside Markdown to the Vitepress component format in order to fix build issues
|
@n-boshnakov: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gardener-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
gardener-prow
bot
added
the
cla: yes
gardener-prow
bot
added
the
size/XXL
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (104)
📝 WalkthroughWalkthroughA comprehensive blog system enhancement that restructures VitePress blog data loading to compute and expose rich metadata: authors (with GitHub profiles), tags (canonicalized across the catalog), and previews (extracted from markdown). New filterable BlogIndex and BlogPostMeta components render this metadata. Shared metadata normalization utilities handle author/tag parsing. An automation script backfills tags and author logins across 80+ existing blog posts. Documentation on blog tags and style is added. Changes
Sequence DiagramsequenceDiagram
participant User as Browser/User
participant BlogIndex as BlogIndex Component
participant DataLoader as blog.data.ts
participant MarkdownSource as Markdown Files
participant Normalize as Metadata Utils<br/>(blogMetadata.ts)
participant Render as VitePress Renderer
User->>BlogIndex: Mount page / navigate
BlogIndex->>DataLoader: Load blog posts data
DataLoader->>MarkdownSource: Read frontmatter & content
MarkdownSource-->>DataLoader: YAML + Markdown body
DataLoader->>Normalize: parseDateValue(frontmatter.date/publishdate)
Normalize-->>DataLoader: {time, string}
DataLoader->>Normalize: extractPreviewFromMarkdown() / extractPreviewFromHtml()
Normalize-->>DataLoader: preview text
DataLoader->>Normalize: normalizeAuthors(frontmatter.authors)
Normalize-->>DataLoader: BlogAuthor[] (with logins, avatars)
DataLoader->>Normalize: normalizeTags(frontmatter.tags)
Normalize-->>DataLoader: string[] (canonicalized)
DataLoader->>Render: Render HTML fragment
Render-->>DataLoader: rendered HTML
DataLoader-->>BlogIndex: Post[] (with authors, tags, preview, date)
BlogIndex->>BlogIndex: Parse tag/text query from URL
BlogIndex->>BlogIndex: Filter posts (AND tag logic + text search)
BlogIndex->>User: Render filtered posts with<br/>tags, authors, preview, date
User->>BlogIndex: Click tag / change search
BlogIndex->>BlogIndex: Update URL state (replaceState)
BlogIndex->>BlogIndex: Re-filter & re-render
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Betterleaks (1.1.1)website/blog/2024/04/04-22-gardener's-registry-cache-extension-another-cost-saving-win-and-more.md/bin/bash: -c: line 1: unexpected EOF while looking for matching `'' 🔧 markdownlint-cli2 (0.21.0)website/blog/2024/04/04-22-gardener's-registry-cache-extension-another-cost-saving-win-and-more.md/bin/bash: -c: line 1: unexpected EOF while looking for matching `'' Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind documentation
/kind enhancement
What this PR does / why we need it:
This PR fixes broken links in the documentation.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Summary by CodeRabbit
Release Notes
New Features
Documentation