do not change the timestamp of a node upon receipt of spoofed data#189
Open
plaguedbypenguins wants to merge 1 commit into
Open
do not change the timestamp of a node upon receipt of spoofed data#189plaguedbypenguins wants to merge 1 commit into
plaguedbypenguins wants to merge 1 commit into
Conversation
centrally collected out-of-band data (eg. from BMCs or a blade chassis) which is then spoofed into the gmond network does not mean that the node is actually up. unfortunately ganglia's notion of a node being "up" is based upon the time when data was last received by the gmond network - the "REPORTED" field in gmond's xml. fix this problem by not updating the node's timestamp in gmond if the data source is spoofed data. users that wish to refresh a node's timestamp with spoofed data (eg. if a node consists of only spoofed data) can use the -H option to gmetric to explicitly send a heartbeat message and keep the node in the "up" state.
Member
|
This may be an unintended consequence however I imagine some people may be relying on this functionality. I am hesitant to merge this. How about adding a config option that defaults to the old behavior however it can be enabled via your code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
centrally collected out-of-band data (eg. from BMCs or a blade
chassis) which is then spoofed into the gmond network does not mean
that the node is actually up. unfortunately ganglia's notion of a node
being "up" is based upon the time when data was last received by the
gmond network - the "REPORTED" field in gmond's xml. fix this problem
by not updating the node's timestamp in gmond if the data source is
spoofed data.
users that wish to refresh a node's timestamp with spoofed data
(eg. if a node consists of only spoofed data) can use the -H option
to gmetric to explicitly send a heartbeat message and keep the node
in the "up" state.