Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Statescript property resolver for constructing Vector2/Vector3/Vector4 values from independently-resolved float components, along with documentation and unit tests.
Changes:
- Introduces
VectorFromValuesResolverto assemble vectors from 2–4 float component resolvers. - Adds unit tests validating output types, resolved values, nested resolver composition, and type validation failures.
- Documents the new resolver and links it from the resolvers index.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/statescript/resolvers/vectorfromvalues-resolver.md | New resolver documentation and examples. |
| docs/statescript/resolvers/README.md | Adds the resolver to the public resolver list. |
| Forge/Statescript/Properties/VectorFromValuesResolver.cs | Implements the new resolver and construction-time type validation. |
| Forge/Statescript/Properties/VectorComponentResolver.cs | Minor formatting/indentation adjustment. |
| Forge.Tests/Statescript/Resolvers/VectorFromValuesResolverTests.cs | Adds coverage for the new resolver’s behavior and validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added