Added component-wise support for DegToRad, RadToDeg and Pow resolvers.#20
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds vector (component-wise) support to several Statescript math resolvers so they can operate on Vector2/Vector3/Vector4 in addition to scalar floating-point inputs.
Changes:
- Extend
DegToRadResolverandRadToDegResolverto return/compute component-wise forVector2/Vector3/Vector4. - Extend
PowResolverto support component-wise exponentiation for matching vector operand types. - Update resolver docs and add/adjust unit tests (including vector approximate-assert helpers).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/statescript/resolvers/radtodeg-resolver.md | Document vector output types and component-wise behavior + example. |
| docs/statescript/resolvers/degtorad-resolver.md | Document vector output types and component-wise behavior + example. |
| docs/statescript/resolvers/pow-resolver.md | Document vector support and adjust composition example. |
| docs/statescript/resolvers/README.md | Update resolver index to reflect new output type support. |
| Forge/Statescript/Properties/RadToDegResolver.cs | Implement vector-aware result typing and component-wise conversion. |
| Forge/Statescript/Properties/DegToRadResolver.cs | Implement vector-aware result typing and component-wise conversion. |
| Forge/Statescript/Properties/PowResolver.cs | Implement vector-aware result typing and component-wise power. |
| Forge.Tests/Statescript/Resolvers/RadToDegResolverTests.cs | Add vector-specific tests and update invalid-type test. |
| Forge.Tests/Statescript/Resolvers/DegToRadResolverTests.cs | Add vector-specific tests and update invalid-type test. |
| Forge.Tests/Statescript/Resolvers/PowResolverTests.cs | Add vector tests and mismatched-vector validation test. |
| Forge.Tests/Helpers/TestUtils.cs | Add BeApproximately overloads for Vector2/Vector3/Vector4. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed