Updated Random Resolvers to include sphere and circle boundary.#17
Merged
Updated Random Resolvers to include sphere and circle boundary.#17
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Statescript random geometry resolvers so RandomInsideCircle / RandomInsideSphere can reach the unit boundary, and RandomOnSphere can include the poles, aligning implementation, docs, and tests.
Changes:
- Switch radius / axial sampling in
GameplayMathUtilstoNextSingleInclusive()for circle/sphere sampling. - Update resolver docs to clarify inclusive boundary behavior and exclusive seam-angle sampling.
- Add/extend resolver tests to cover boundary reachability and sampling-method call patterns (plus add range edge-case tests for
RandomResolver).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/statescript/resolvers/randomonsphere-resolver.md | Documents pole inclusion + exclusive seam-angle sampling. |
| docs/statescript/resolvers/randominsidesphere-resolver.md | Documents inclusive boundary behavior and sampling details. |
| docs/statescript/resolvers/randominsidecircle-resolver.md | Documents inclusive boundary behavior and exclusive angle seam. |
| docs/statescript/resolvers/randomdirection-resolver.md | Adds seam-angle sampling note. |
| Forge/Statescript/Properties/GameplayMathUtils.cs | Uses inclusive random sampling for radius/axial terms to include boundaries. |
| Forge.Tests/Statescript/Resolvers/RandomResolverTests.cs | Adds tests for reversed/equal bounds returning min without RNG calls. |
| Forge.Tests/Statescript/Resolvers/RandomOnSphereResolverTests.cs | Adds tests for pole reachability and inclusive/exclusive call usage. |
| Forge.Tests/Statescript/Resolvers/RandomInsideSphereResolverTests.cs | Adds tests asserting sphere-boundary reachability and call patterns. |
| Forge.Tests/Statescript/Resolvers/RandomInsideCircleResolverTests.cs | Adds tests asserting circle-boundary reachability and call patterns. |
| Forge.Tests/Statescript/Resolvers/RandomDirectionResolverTests.cs | Adds tests around seam-angle behavior and near-2π boundary direction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed