Extended RandomResolver to support inclusive max range.#16
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the statescript RandomResolver and the core IRandom abstraction to support inclusive max bounds (with configurability), and refreshes docs/tests to reflect the new behavior.
Changes:
- Added inclusive-range methods to
IRandom(NextIntInclusive,NextSingleInclusive,NextDoubleInclusive,NextInt64Inclusive). - Extended
RandomResolverwith amaxInclusiveconfiguration (defaulting to inclusive) and updated float/double behavior accordingly. - Updated documentation and expanded unit tests/helpers for the new inclusive/exclusive paths.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/statescript/resolvers/random-resolver.md | Documents the new maxInclusive parameter and inclusive-by-default behavior. |
| docs/effects/components.md | Updates the documented IRandom interface to include inclusive methods. |
| Forge/Statescript/Properties/RandomResolver.cs | Implements inclusive/exclusive max selection and new float/double handling. |
| Forge/Core/IRandom.cs | Adds new inclusive methods to the public random provider interface. |
| Forge.Tests/Statescript/Resolvers/RandomResolverTests.cs | Adds coverage for inclusive-by-default and exclusive configuration paths. |
| Forge.Tests/Helpers/StatescriptTestHelpers.cs | Extends test random providers to implement the new IRandom members. |
| Forge.Tests/Effects/ChanceToApplyComponentTests.cs | Updates the test random provider to satisfy the expanded IRandom interface. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Changed