Skip to content

release: prepare v1.7.3#91

Merged
gaelic-ghost merged 6 commits into
mainfrom
schema/codex-cli-0-139-refresh
Jun 13, 2026
Merged

release: prepare v1.7.3#91
gaelic-ghost merged 6 commits into
mainfrom
schema/codex-cli-0-139-refresh

Conversation

@gaelic-ghost

@gaelic-ghost gaelic-ghost commented Jun 13, 2026

Copy link
Copy Markdown
Owner

Release

  • prepares v1.7.3 from branch schema/codex-cli-0-139-refresh
  • keeps protected main updates behind pull request review and CI
  • release tag v1.7.3 will be created after CI and the review-comment gate pass, so failed or still-discussed release candidates do not get tagged

Review Loop

Before merge and tagging, scripts/repo-maintenance/release.sh watches CI and stops on review comments unless the maintainer has already addressed or resolved them and reruns with --review-comments-addressed.

Why:
- the installed Codex CLI is 0.139.0 while SwiftASB still documented and enforced a 0.138.x reviewed window
- the promoted v0.139.0 wire delta is intentionally small and keeps the new MCP status thread target internal-only for now

Verification:
- swift build
- swift test
- bash scripts/repo-maintenance/validate-all.sh
- uv run pytest
- git diff --check
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@gaelic-ghost, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 50 minutes and 1 second. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: da957836-17d8-4b4d-8936-2bce5865f6ba

📥 Commits

Reviewing files that changed from the base of the PR and between 47ba5eb and d0919e7.

📒 Files selected for processing (3)
  • ROADMAP.md
  • docs/agents/reports/2026-06-11-agentsb-schema-review.md
  • scripts/repo-maintenance/version-bump.sh
📝 Walkthrough

Walkthrough

SwiftASB v1.7.3 patch release: bumps CodexCLIExecutableResolver.Version.latestSupportedPublicRelease from 0.138.0 to 0.139.0, propagates the 0.139.x compatibility window across all Swift/Python tests and tooling, adds a regression test that asserts MCP server status diagnostics remain app-wide when the wire payload carries a threadId, and updates all documentation and release artifacts.

Changes

SwiftASB v1.7.3: Codex CLI 0.139.x compatibility and threadId internalization

Layer / File(s) Summary
Core compatibility constant and wire script
Sources/SwiftASB/Transport/CodexCLIExecutableResolver.swift, scripts/generate-wire-types.sh
latestSupportedPublicRelease bumped from 0.138.0 to 0.139.0; wire-type generation script default schema version updated to v0.139.0.
threadId internalization: test support and regression
Tests/SwiftASBTests/Public/CodexAppServerTestSupport.swift, Tests/SwiftASBTests/Public/CodexAppServerDiagnosticsTests.swift
emitMcpServerStatusUpdated gains optional threadID parameter with conditional payload inclusion; new regression test verifies mcpServerStatusChanged diagnostics expose nil threadID/turnID even when the wire payload carries a thread identifier.
Swift test suite 0.139.x updates
Tests/SwiftASBTests/Public/CodexAppServerTests.swift, Tests/SwiftASBTests/Public/CodexAppServerLiveIntegrationTests.swift, Tests/SwiftASBTests/Transport/CodexCLIExecutableResolverTests.swift
Fake resolver versions, mocked codex-cli version strings, and all compatibility window assertions updated from 0.138.x to 0.139.x across all resolver and server test scenarios.
AgentSB Python tests
Tools/AgentSB/tests/test_cli.py, Tools/AgentSB/tests/test_tools.py
CLI inspect and repo-facts assertions updated to expect reviewed_codex_cli_window.window == "0.139.x".
Release notes and README
docs/releases/v1.7.3.md, README.md, docs/maintainers/v1-public-api-audit.md
Adds v1.7.3 release notes (what changed, no breaking changes, migration notes, verification commands); README version references, Package.swift example, and compatibility note updated to v1.7.3 / 0.139.x.
Maintainer docs and ROADMAP
docs/maintainers/interactive-lifecycle-release-boundary.md, docs/maintainers/quicktype-codegen-notes.md, docs/agents/reports/2026-06-11-agentsb-schema-review.md, ROADMAP.md
Lifecycle boundary doc gains 0.139.x window and internal threadId classification; codegen notes current batch updated to v0.139.0; new agent schema review report added; ROADMAP updated with v1.7.3 prep checklist, history entries, and all 0.138.x→0.139.x narrative references.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • gaelic-ghost/SwiftASB#76: Same pattern of bumping latestSupportedPublicRelease in CodexCLIExecutableResolver.swift to a new reviewed compatibility window with corresponding test and doc updates.
  • gaelic-ghost/SwiftASB#80: Directly updates the same latestSupportedPublicRelease constant and documented compatibility-window expectations to an adjacent 0.13x range.
  • gaelic-ghost/SwiftASB#89: Prior compatibility/schema refresh that advanced CodexCLIExecutableResolver.Version.latestSupportedPublicRelease and scripts/generate-wire-types.sh default in the same direction as this PR.

Suggested labels

enhancement

🐇 A hop through versions, one-three-nine,
The threadId stays hidden, that's by design!
The window refreshed, the resolver in sync,
Diagnostics stay app-wide — no thread in the link.
v1.7.3 hops onto the shelf,
This little rabbit tags releases itself! 🏷️

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the PR’s main release-preparation change for v1.7.3.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch schema/codex-cli-0-139-refresh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 47ba5eb7bb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ROADMAP.md Outdated
Comment on lines +1648 to +1651
- 2026-06-09: Published `v1.7.3` with the ASBPresentation foundation, first
ASBAppKit thread sidebar view, Codex CLI `0.138.x` generated-wire refresh,
and PolyForm Noncommercial license transition.
- 2026-06-09: Prepared the `v1.7.2` release branch with the ASBPresentation
- 2026-06-09: Prepared the `v1.7.3` release branch with the ASBPresentation

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep old release history at v1.7.2

These June 9 history entries describe the prior ASBPresentation/ASBAppKit and Codex CLI 0.138.x release, so changing them to v1.7.3 makes the roadmap claim that v1.7.3 was already published/prepared before the new June 13 v1.7.3 entry. This will mislead release audits; keep these historical entries on the version that actually shipped that work (v1.7.2).

Useful? React with 👍 / 👎.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/agents/reports/2026-06-11-agentsb-schema-review.md`:
- Around line 48-54: The report file contains sensitive machine-local
information that should not be committed. In the Repository root field (line
48), replace the absolute path `/Users/galew/.codex/worktrees/8d09/SwiftASB`
with a repo-relative path like `.` or `./` to indicate the repository root, or
omit this field entirely. Additionally, remove or redact the Git dirty state
field on line 50 as it represents environment-specific state that is not
relevant to a committed report. Keep only the necessary metadata that documents
the review context without exposing user-specific paths or local machine state.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 022ddfe2-1213-445c-ba30-ca2f49d21ff0

📥 Commits

Reviewing files that changed from the base of the PR and between 94019a8 and 47ba5eb.

⛔ Files ignored due to path filters (1)
  • Sources/SwiftASB/Generated/CodexWire/Latest/CodexLifecycleV2Batch+JSONValue.swift is excluded by !**/generated/**
📒 Files selected for processing (16)
  • README.md
  • ROADMAP.md
  • Sources/SwiftASB/Transport/CodexCLIExecutableResolver.swift
  • Tests/SwiftASBTests/Public/CodexAppServerDiagnosticsTests.swift
  • Tests/SwiftASBTests/Public/CodexAppServerLiveIntegrationTests.swift
  • Tests/SwiftASBTests/Public/CodexAppServerTestSupport.swift
  • Tests/SwiftASBTests/Public/CodexAppServerTests.swift
  • Tests/SwiftASBTests/Transport/CodexCLIExecutableResolverTests.swift
  • Tools/AgentSB/tests/test_cli.py
  • Tools/AgentSB/tests/test_tools.py
  • docs/agents/reports/2026-06-11-agentsb-schema-review.md
  • docs/maintainers/interactive-lifecycle-release-boundary.md
  • docs/maintainers/quicktype-codegen-notes.md
  • docs/maintainers/v1-public-api-audit.md
  • docs/releases/v1.7.3.md
  • scripts/generate-wire-types.sh

Comment thread docs/agents/reports/2026-06-11-agentsb-schema-review.md Outdated
@gaelic-ghost gaelic-ghost merged commit aa737f1 into main Jun 13, 2026
2 checks passed
@gaelic-ghost gaelic-ghost deleted the schema/codex-cli-0-139-refresh branch June 13, 2026 23:27

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d0919e79d3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +89 to +93
index($0, "next meaningful work after the ") && index($0, "patch release") {
gsub("`v" old_version "`", "`v" new_version "`")
}
index($0, "patch prep") && index($0, "updates the current release reference again") {
gsub("`v" old_version "`", "`v" new_version "`")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update all current release slice references

In the standard release flow, release.sh invokes this hook before committing the bump, but this line-oriented whitelist misses ROADMAP's Current Patch Release Slice entries such as This slice records..., ### Planned for..., and the release-notes/tagging bullets; it also misses the wrapped patch prep sentence because the two substrings are on different lines. Running the hook on this tree for 1.7.4 leaves README at v1.7.4 while ROADMAP still contains v1.7.3 in that current-release section, which makes future release audit docs inconsistent.

Useful? React with 👍 / 👎.

@coderabbitai coderabbitai Bot mentioned this pull request Jun 16, 2026
@coderabbitai coderabbitai Bot mentioned this pull request Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant