fix: reduce buildScoreCache example size and clean up export_abnFit example#261
Open
LeonidasZhak wants to merge 1 commit into
Open
fix: reduce buildScoreCache example size and clean up export_abnFit example#261LeonidasZhak wants to merge 1 commit into
LeonidasZhak wants to merge 1 commit into
Conversation
…xample - Reduce N from 1e6 to 100 in buildScoreCache() example (issue furrer-lab#254) - Remove unnecessary data() call from export_abnFit() example - Fix missing distributions in export_abnFit() example (b4, b5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #254 by making the following documentation improvements:
Changes
R/build_score_cache.R (line 283): Reduced N from 1e6 to 100 in the buildScoreCache() example. 1 million observations is excessive for a simple example; 100 is sufficient to demonstrate the workflow.
R/export.R (lines 152-161): Cleaned up export_abnFit() example:
data(ex1.dag.data)call (data is available via lazy loading)library(abn)call (not needed in examples)b4 = "binomial"andb5 = "binomial"to match the 10 variables inex1.dag.dataman/buildScoreCache.Rd and man/export_abnFit.Rd: Updated Rd files to match roxygen source
Validation
Related Issues
export_abnFit#240 (export_abnFit example)