Skip to content

Bumping versions #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
funkemunky merged 1 commit into from
Feb 21, 2026
Merged

Bumping versions #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v5
- uses: actions/checkout@v6

Copilot AI Feb 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow mixes a SHA-pinned action (maven-dependency-submission-action) with tag-based actions. For supply-chain hardening, consider pinning actions/checkout to a specific commit SHA as well (or otherwise document why tags are acceptable here).

Suggested change
- uses: actions/checkout@v6
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # actions/checkout@v6

Copilot uses AI. Check for mistakes.
with:
submodules: true
- name: Set up JDK 17
- name: Set up JDK 21
uses: actions/setup-java@v5
with:
java-version: '17'
java-version: '21'
distribution: 'zulu'
Comment on lines +17 to 21

Copilot AI Feb 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI now installs JDK 21, but the Maven build is configured to compile for Java 17 (pom.xml sets maven.compiler.source/target=17). Building with a newer JDK while only using source/target can accidentally compile against JDK 21 APIs and still emit Java 17 bytecode, which can fail at runtime on Java 17. Either keep the CI JDK at 17, or switch the build to use a proper cross-compilation setting (e.g., maven.compiler.release=17 and/or toolchains) if you intentionally want to build on JDK 21.

Copilot uses AI. Check for mistakes.
cache: maven
- name: Set up Maven
Expand All @@ -32,12 +32,12 @@ jobs:
uses: advanced-security/maven-dependency-submission-action@571e99aab1055c2e71a1e2309b9691de18d6b7d6

- name: Upload Enterprise
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
Comment on lines 34 to 36

Copilot AI Feb 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider pinning actions/upload-artifact to a specific commit SHA (instead of a moving v6 tag) to reduce the risk of supply-chain compromise and keep action updates explicit/reviewable.

Copilot uses AI. Check for mistakes.
name: EnterpriseAnticheat
path: Anticheat/target/AntiCheat-*.jar
- name: Upload API
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
Comment on lines 39 to 41

Copilot AI Feb 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider pinning actions/upload-artifact to a specific commit SHA (instead of a moving v6 tag) to reduce the risk of supply-chain compromise and keep action updates explicit/reviewable.

Copilot uses AI. Check for mistakes.
name: API
path: API/target/API-*.jar
Loading