Better method of specifying a target source property type for FGD entities - #261
Open
redxdev wants to merge 1 commit into
Open
Better method of specifying a target source property type for FGD entities#261redxdev wants to merge 1 commit into
redxdev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternate take on fixing #215 as opposed to using
StringNamelike #240 and I believe sets a better standard for how to handle "extended" property types going forward.The idea is that to make a target_source property you make a new inline resource of type
FuncGodotTargetSourcePropertyinstead of anObject(since that won't save properly and gets reset to null on reload of the entity definition resource).A benefit of this approach for future property type support is that additional options could be made available in the resource, such as a proper default value instead of it always being empty.
An alternate approach would be to have a more generic extended property data resource type for specifying custom FGD types like so:
but that requires a bit more work.