Added new PM_TYPES and more robust handling #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over at hacs-e3dc user @mkkri reported a new PM_TYPE "11"
After some analysis this seems to correspond to Produktionszähler (keine Speicherung) which is mentioned in the S10X installation manual but no ID is given.
This PR adds the ID 11 as well as the other ones mentioned in the Modbus Spec "Datenanzeige" und "Regelungsbypass".
To avoid crashes in case of future new IDs in the future, i added in addition more robust checking of the PM and PVI types.