Skip to content

Fix nitpicks: Remove unused imports and unnecessary method arguments #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmjcode merged 2 commits into from
May 12, 2026
Merged

Fix nitpicks: Remove unused imports and unnecessary method arguments #53

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
978de5e
Remove an unused import
bmjcode May 5, 2026
2ce1b63
Omit unnecessary arguments to self.mapFromPage() in PdfPage.text()
bmjcode May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions qpageview/pdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import platform

from PyQt6.QtCore import Qt, QByteArray, QModelIndex, QRect, QRectF, QSize, QUrl
from PyQt6.QtGui import QPainter
from PyQt6.QtPdf import QPdfDocument, QPdfDocumentRenderOptions

# Check for PDF link support (added in Qt 6.6)
Expand Down Expand Up @@ -159,7 +158,7 @@ def ident(self):

def text(self, rect):
"""Returns text inside rectangle."""
rectf = self.mapFromPage(self.pageWidth, self.pageHeight).rect(rect)
rectf = self.mapFromPage().rect(rect)
with locking.lock(self.document):
return self.document.getSelection(
self.pageNumber, rectf.topLeft(), rectf.bottomRight()).text()
Expand Down
Loading