Remove unreleased electrical component category/type wrappers#233
Merged
Conversation
llucax
requested review from
ela-kotulska-frequenz
and removed request for
a team
July 3, 2026 08:29
github-actions
Bot
added
part:docs
llucax
enabled auto-merge
July 3, 2026 08:46
Contributor
|
will wait for the rebase before reviewing. |
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
These deprecated attributes will be removed in the next commits. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Contributor
Author
|
Rebased. |
Contributor
Author
|
I was very silly not to realize in #222 that most of the stuff I deprecated was actually never released (in this repo). |
ela-kotulska-frequenz
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The earlier deprecation PR #222 deprecated
ElectricalComponentCategoryand theXxxTypeenums and.categoryand.typeattributes, but most of those symbols were yet unreleased, so deprecating them makes no sense.This PR remove the unreleased deprecated symbols:
ElectricalComponent.categoryand(Battery|Inverter|EvCharger).typeattributes, except forUnrecognized*classes andMismatchesCategoryElectricalComponent, as they carry the raw protobuf value that could be used for forward compatibility.BatteryType,InverterType,EvChargerTypeenums, and their protobuf conversion functions.ElectricalComponentCategoryand its proto converters are kept as deprecated because they were already released and still present in v0.4.0.Part of #223.