fix: default exchange_rate to 1.0 when it is 0.0 or None in Expense Claim advances - #5011
Open
mujeerhashmi wants to merge 1 commit into
Open
fix: default exchange_rate to 1.0 when it is 0.0 or None in Expense Claim advances#5011mujeerhashmi wants to merge 1 commit into
mujeerhashmi wants to merge 1 commit into
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Confidence Score: 4/5The implementation appears safe to merge, though the requested Journal Entry regression assertion remains absent. The new test validates the zero gain/loss value but does not verify that no gain/loss Journal Entry was created. Files Needing Attention: hrms/hr/doctype/expense_claim/test_expense_claim.py Reviews (3): Last reviewed commit: "fix: default exchange_rate to 1.0 when i..." | Re-trigger Greptile |
mujeerhashmi
force-pushed
the
fix-exchange-rate-default
branch
2 times, most recently
from
July 28, 2026 08:55
a9f96fd to
45495b1
Compare
mujeerhashmi
force-pushed
the
fix-exchange-rate-default
branch
from
July 28, 2026 08:56
45495b1 to
355ec78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that when the exchange rate is not set (is 0.0 or None) for an Employee Advance, it defaults to 1.0. This prevents the system from calculating an incorrect exchange gain/loss difference and incorrectly attempting to create a Journal Entry.