fix: PostgreSQL compatibility — explicit numeric comparisons

[skanderphilipp]

Fix PostgreSQL error during Frappe v17 (develop) setup with PostgreSQL backend:

update_employee_advance_status.py — bare numeric fields in WHERE

The post-install patch used bare return_amount and claimed_amount (Currency fields, stored as numeric) in boolean context:

.where((advance.return_amount) & (advance.paid_amount == advance.return_amount))

PostgreSQL rejects numeric types in boolean context with:

argument of AND must be type boolean, not type numeric

Fix: Changed bare numeric references to explicit > 0 comparisons:

.where((advance.return_amount > 0) & (advance.paid_amount == advance.return_amount))

Semantically equivalent — both return_amount and claimed_amount are non-negative currency values. Backwards-compatible with MariaDB.

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge.

Explicit positive comparisons preserve the established non-negative amount semantics while producing valid boolean predicates on PostgreSQL.

_{Reviews (1): Last reviewed commit: "fix: PostgreSQL compatibility — explicit..." | Re-trigger Greptile}