fix(payroll): filter submitted records in get_payroll_entries_for_jv - #4997
Open
pratheep-bit wants to merge 1 commit into
Open
fix(payroll): filter submitted records in get_payroll_entries_for_jv#4997pratheep-bit wants to merge 1 commit into
pratheep-bit wants to merge 1 commit into
Conversation
pratheep-bit
requested review from
AyshaHakeem,
iamkhanraheel and
ruchamahabal
as code owners
July 25, 2026 03:30
Contributor
Confidence Score: 5/5Safe to merge — the change is a single targeted filter addition with no side effects on other query paths. The fix is minimal and correct: adding Files Needing Attention: No files require special attention. Reviews (2): Last reviewed commit: "fix(payroll): filter submitted records i..." | Re-trigger Greptile |
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
deepeshgarg007
approved these changes
Jul 27, 2026
pratheep-bit
force-pushed
the
fix/payroll-entries-for-jv-docstatus-filter
branch
from
July 29, 2026 08:41
9ff2e68 to
d22b2e3
Compare
Contributor
Author
|
Hi @iamkhanraheel, Updated in PR #4997 to create a Draft Payroll Entry and assert that it is excluded () from the query results. Force-pushed clean commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
.where(PayrollEntry.docstatus == 1)condition to the QueryBuilder query inget_payroll_entries_for_jv().Payroll Entryis a submittable Doctype. Previously, Draft (docstatus=0) and Cancelled (docstatus=2) records were returned in Journal Entry selection dialogs. Addingdocstatus = 1ensures only submitted payroll entries are available for linking in Journal Entries.test_get_payroll_entries_for_jv_filters_docstatusintest_payroll_entry.py.