feat: enhance Unpaid Expense Claim report - #4994
Open
akhtarmohsin wants to merge 2 commits into
Open
Conversation
- Add Company, Department, Branch filters - Department filter scoped to selected company - Employee filter scoped to selected company - Add Posting Date, Company, Department, Branch columns - Add Group By filter (Employee, Department, Branch) with subtotals - Show 'No record found' message when no data exists
Contributor
Confidence Score: 5/5Safe to merge; the query and filter logic are correct, with only a minor display inconsistency in the group header rows. The query changes are straightforward and additive. The group-by aggregation logic is sound. The only issue is cosmetic: header rows for Department/Branch groupings show the group label in the Employee column rather than the relevant column. hrms/hr/report/unpaid_expense_claim/unpaid_expense_claim.py — group header row key assignment in build_grouped_result. Reviews (2): Last reviewed commit: "fix: address review comments on Unpaid E..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
- Remove unused Order import - Return empty data silently instead of showing msgprint dialog
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screen.Recording.2026-07-24.at.12.26.44.PM.mov
no-docs