Skip to content

Feat/group company employee analytics - #4963

Open
akhtarmohsin wants to merge 4 commits into
frappe:developfrom
akhtarmohsin:feat/group-company-employee-analytics
Open

Feat/group company employee analytics#4963
akhtarmohsin wants to merge 4 commits into
frappe:developfrom
akhtarmohsin:feat/group-company-employee-analytics

Conversation

@akhtarmohsin

@akhtarmohsin akhtarmohsin commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

What changed

The Employee Analytics report now supports Group Companies.

When a company is set up as a parent with child companies, selecting the parent in the report shows combined data from all child companies. Selecting a child company still shows only that company's data.

Screen.Recording.2026-07-20.at.4.18.41.PM.mov

no-docs

@greptile-apps

greptile-apps Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Safe to merge — the nested-set query correctly includes all descendants, and both the employee list and chart count use the same company set.

The core logic is correct: get_companies builds the full subtree, and every downstream query consistently uses the resulting list. No data loss or incorrect filtering paths identified.

No files require special attention.

Reviews (6): Last reviewed commit: "fix: set is_group on parent company in t..." | Re-trigger Greptile

Comment thread hrms/hr/report/employee_analytics/employee_analytics.py
@akhtarmohsin
akhtarmohsin force-pushed the feat/group-company-employee-analytics branch from 663ae9d to 4c0a4ab Compare July 20, 2026 11:57
@mergify

mergify Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant