feat: email notifications for job offers and interview scheduling - #4919
feat: email notifications for job offers and interview scheduling#4919iamkhanraheel wants to merge 13 commits into
Conversation
- Custom button on submitted Job Offer (relabels to Resend after first send) - Dialog with Email Template and Print Format selectors + Preview - Default "Job Offer Letter" email template
Confidence Score: 4/5Safe to merge with the caveat that in-app desk notifications for interviewers will silently target Employee IDs rather than Frappe user names — emails go out correctly, but notification logs may not reach the right users. The core email flows are sound and the prior Communication-based false-positive resend bug is fixed. The remaining concern is that make_notification_logs in send_interview_confirmation (and send_daily_feedback_reminder) receives [d.interviewer …] — Employee docnames — while the function expects Frappe user login names. Notifications will be created for non-existent users or the wrong users in those paths. hrms/hr/doctype/interview/interview.py — the make_notification_logs calls need the Employee ID resolved to user_id before being passed in. Reviews (8): Last reviewed commit: "fix(job_offer): remove hardcoded chrome ..." | Re-trigger Greptile |
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
3943009 to
14d275f
Compare
Job Offer
JobOfferEmail.mov
Interview Confirmation Email
Schedule Interview & send confirmation later 👇
InterviewSchedule.Confirm.mov
Schedule & send confirmation at same time 👇
InterviewConfirmation.mov
Interview Reminder & Feedback Reminder
Closes: #3305